emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Out-of-date completions for `read-buffer'


From: Eli Zaretskii
Subject: Re: Out-of-date completions for `read-buffer'
Date: Sat, 02 Sep 2006 14:23:37 +0300

> Date: Mon, 28 Aug 2006 13:25:47 -0700 (PDT)
> From: "Stuart D. Herring" <address@hidden>
> 
> > Your patch is clean, but we should call the new function
> > internal-complete-buffer so that people won't complain that it isn't
> > documented it in the Lisp Manual.
> >
> > Would someone (Eli?) please install the patch, with that change?
> 
> Not to harass, but this hasn't happened in ten days, so I thought I'd
> re-raise it.  The patch's message is at
> http://lists.gnu.org/archive/html/emacs-devel/2006-08/msg00574.html.

Installed.

Your original patch didn't compile:

  minibuf.c: In function `Fread_buffer':
  minibuf.c:1218: error: incompatible type for argument 2 of `Fcompleting_read'
  make[1]: *** [minibuf.o] Error 1

I fixed that by using `intern ("internal-complete-buffer")' instead of
`Sinternal_complete_buffer'.  I also expanded the doc string to
explain the arguments.

Thanks.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]