Re: rcirc changes

[Ryan Yeske]

Chong Yidong <address@hidden> writes:

> Richard Stallman <address@hidden> writes:
>
>> We're waiting for Ryan Yeske's changes about scrolling to
>> be installed in rcirc.el.  Would someone please install them?
>
> Done.  (I updated FOR-RELEASE too).

Thanks for installing this.  I since found a problem with how the
computation was done, it is not correct when there are continuations
of long-lines.

Here is a fix.

*** rcirc.el    12 Sep 2006 12:04:44 -0700      1.28
--- rcirc.el    12 Sep 2006 14:46:20 -0700      
***************
*** 1260,1270 ****
                              (with-current-buffer (window-buffer w)
                                (when (eq major-mode 'rcirc-mode)
                                  (with-selected-window w
!                                   (when (<= (- (window-height) 
!                                                (- (line-number-at-pos
!                                                    (window-point))
!                                                   (line-number-at-pos
!                                                    (window-start)))
                                                 1)
                                              0)
                                      (recenter -1)))))))
--- 1260,1269 ----
                              (with-current-buffer (window-buffer w)
                                (when (eq major-mode 'rcirc-mode)
                                  (with-selected-window w
!                                   (when (<= (- (window-height)
!                                                (count-screen-lines
!                                                 (window-point)
!                                                 (window-start))
                                                 1)
                                              0)
                                      (recenter -1)))))))