[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: shell-command - missing shell-quote-argument for program?
From: |
Lennart Borgman |
Subject: |
Re: shell-command - missing shell-quote-argument for program? |
Date: |
Fri, 06 Oct 2006 15:20:51 +0200 |
User-agent: |
Thunderbird 1.5.0.7 (Windows/20060909) |
Lennart Borgman wrote:
Lennart Borgman wrote:
In some places the program to run from `shell-command' is not quoted
by `shell-quote-argument'. Examples are the calls in emerge.el.
Should not the program name be quoted by `shell-quote-argment' when
it is possible?
And I should have mentioned `shell-command-to-string' to of course.
More examples of probably missing shell quotings are in
- filesets.el
The author of filesets Thomas Link has replied to me that he currently
does not use Emacs and cannot maintain filesets.el until that situation
changes.
I myself therefore suggest the following patch to filesets.el:
Index: filesets.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/filesets.el,v
retrieving revision 1.29
diff -c -r1.29 filesets.el
*** filesets.el 13 Aug 2006 17:05:12 -0000 1.29
--- filesets.el 6 Oct 2006 13:15:12 -0000
***************
*** 1701,1707 ****
ok)
t)))
(when ok
! (let ((cmd (format txt (buffer-file-name))))
(message "Filesets: %s" cmd)
(filesets-cmd-show-result cmd
(shell-command-to-string cmd))))))
--- 1701,1707 ----
ok)
t)))
(when ok
! (let ((cmd (format txt (shell-quote-argument (buffer-file-name)))))
(message "Filesets: %s" cmd)
(filesets-cmd-show-result cmd
(shell-command-to-string cmd))))))
- Re: shell-command - missing shell-quote-argument for program?, (continued)
- Re: shell-command - missing shell-quote-argument for program?, Kim F. Storm, 2006/10/06
- Re: shell-command - missing shell-quote-argument for program?, Richard Stallman, 2006/10/06
- Re: shell-command - missing shell-quote-argument for program?, Andreas Schwab, 2006/10/07
- Re: shell-command - missing shell-quote-argument for program?, Richard Stallman, 2006/10/07
- Re: shell-command - missing shell-quote-argument for program?, Andreas Schwab, 2006/10/08
- Re: shell-command - missing shell-quote-argument for program?, Richard Stallman, 2006/10/08
- Re: shell-command - missing shell-quote-argument for program?, Andreas Schwab, 2006/10/08
- Re: shell-command - missing shell-quote-argument for program?, Richard Stallman, 2006/10/09
- Re: shell-command - missing shell-quote-argument for program?, Kim F. Storm, 2006/10/09
Re: shell-command - missing shell-quote-argument for program?, Kim F. Storm, 2006/10/06
Re: shell-command - missing shell-quote-argument for program?,
Lennart Borgman <=
- Re: shell-command - missing shell-quote-argument for program?, Kim F. Storm, 2006/10/12
- Re: shell-command - missing shell-quote-argument for program?, Richard Stallman, 2006/10/12
- Re: shell-command - missing shell-quote-argument for program?, Lennart Borgman, 2006/10/13
- Re: shell-command - missing shell-quote-argument for program?, Lennart Borgman, 2006/10/13
- Re: shell-command - missing shell-quote-argument for program?, Thomas Link, 2006/10/14
Re: shell-command - missing shell-quote-argument for program?, Thomas Link, 2006/10/13
Re: shell-command - missing shell-quote-argument for program?, Lennart Borgman, 2006/10/13
Re: [Bulk] Re: shell-command - missing shell-quote-argument for program?, Thomas Link, 2006/10/14
Re: shell-command - missing shell-quote-argument for program?, Richard Stallman, 2006/10/14
Re: shell-command - missing shell-quote-argument for program?, Eli Zaretskii, 2006/10/14