[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} do
From: |
Giorgos Keramidas |
Subject: |
Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist |
Date: |
Thu, 12 Oct 2006 15:35:56 +0300 |
On 2006-10-12 14:59, Kenichi Handa <address@hidden> wrote:
> In article <address@hidden>,
> Giorgos Keramidas <address@hidden> writes:
>
> > The current `make install' target of the leim/ subdirectory has a subtle
> > problem when ${prefix}/share/emacs/22.0.50/leim does not exist at all.
>
> Oops, my last change was not sufficient.
>
> > The following patch fixes this.
>
> It seems that the patch removes CVS and etc. from the current
> directory if it equals to INSTALLDIR.
Yes, the first version of the patch I send was buggy in this way.
Sorry for not having tested it as thoroughly.
> So, I've just installed the different fix. Could you please try it?
I just pulled the changes from CVS.
It seems to include this part:
+ if [ ! -d ${INSTALLDIR} ] ; then \
+ ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
+ else true; fi
We don't really *need* to have an else branch in all statements. We can
write this as:
+ if [ ! -d ${INSTALLDIR} ] ; then \
+ ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
+ fi
Apart from this minor difference, this is identical to the second
version of the same patch I posted, so I'm fairly confident it works.
I will test it with a new build later today though.
Thank you for the ultra fast responses :)