Re: Re[2]: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Juanma Barranquero]

On 6/25/07, Eric M. Ludlam <address@hidden> wrote:

>   I suspect your patch might leave a bunch of invisible frames about,
> but it's been a while since I've been in that code so I'm not sure.

At the very least, this patch should be committed. There's no point in
trying to delete-frame nil.

OTOH, I confess I don't entirely understand the way speedbar handles
frames. For example:

emacs -q
M-x speedbar-frame-mode
"q" on the speedbar frame
M-: (frame-list)    => the speedbar frame still exists

but

emacs -q
C-x 5 2
M-x speedbar-frame-mode
"q" on the speedbar frame
M-: (frame-list)   => the speedbar frame does not exist

??

            Juanma


Index: lisp/speedbar.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/speedbar.el,v
retrieving revision 1.87
diff -u -2 -r1.87 speedbar.el
--- lisp/speedbar.el    19 Feb 2007 13:37:23 -0000      1.87
+++ lisp/speedbar.el    25 Jun 2007 22:39:43 -0000
@@ -1054,7 +1054,8 @@
If the deleted frame is the frame SPEEDBAR is attached to,
we need to delete speedbar also."
-  (let ((frame-to-be-deleted (car (car (cdr e)))))
-    (if (eq frame-to-be-deleted dframe-attached-frame)
-       (delete-frame speedbar-frame)))
+  (when speedbar-frame
+    (let ((frame-to-be-deleted (car (car (cdr e)))))
+      (if (eq frame-to-be-deleted dframe-attached-frame)
+         (delete-frame speedbar-frame))))
  )