RE: Patch: prefer-window-split-horizontally

[klaus.berndl]

Tassilo Horn wrote:
> Stefan Monnier <address@hidden> writes:
> 
>>> Since `split-window-function' would default to
>>> `split-window-vertically' it shouldn't make a difference.  And of
>>> course `split-window-function' may only be used in `split-window' if
>>> its parameters SIZE and HORFLAG are omitted.
>> 
>>> Do you think there are packages that would still be break on this?
>>> If yes, then maybe the packages should be adapted to the new
>>> behavior (by adding the required params to `split-window' if they
>>> need fine grained control) and not the other way around.
>> 
>> Changing the behavior of split-window so that it uses something like
>> split-window-function only makes sense if we want to change the
>> behavior seen by current callers of this function.
> 
> That's the case, isn't it?  And the behavior would only change if
> users modify `split-window-function'.  So I don't see a problem here.
> 
>> If all/most current callers of this function would rather have it
>> stay the way it is and if all callers that want it changed do not
>> call it directly (or call it interactively), then we're better off
>> changing the other place where split-window is called (i.e.
>> display-buffer) or creating a new function.
> 
> I cannot follow you completely.  In most cases it's not the caller who
> should decide how windows are split but the user, who wants to use his
> screen as good as possible.
> 
> Beside Gnus and ECB I don't know any packages that have to care of how
> windows have to be split.  And at least for Gnus I can say that it
> does the split using all params `split-window' has, and thus
> `split-window-function' wouldn't be used.

If it's usefull for you, i can check this for ECB - can you please
repeat exactly what i have to check! Then i can do this at weekend...

Klaus

> 
> Bye,
> Tassilo
> 
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/emacs-devel