emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

vc-svn-print-log change broke log-view-diff


From: Bernhard Herzog
Subject: vc-svn-print-log change broke log-view-diff
Date: Tue, 21 Aug 2007 20:14:25 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux)

Hi,

log-view mode has been broken a little for a while in HEAD when using
SVN.  vc-svn-print-log helpfully inserts a line indicating which file
the log is for:

      ;; Add a line to tell log-view-mode what file this is.
      (insert "Working file(s): " (vc-delistify (mapcar 'file-relative-name 
files)) "\n"))

The problem is the "(s)" which is not matched by the regular expression
in log-view-file-re.  As a result log-view-diff fails with the message 

   Search failed: "^\\(?:Working file: \\(?1:.+\\)\\|\\(?:SCCS/s\\.\\|Changes 
to \\)\\(?1:.+\\):\\)

The problem was probably introduced by the following commit:

2007-07-18  Eric S. Raymond  <address@hidden>

        * vc-hooks.el: Generalize stay-local-p to operate on lists of
        files.  Change two keybindings to point to new function names.
        * vc-arch.el, vc-bzr.el, vc-cvs.el, vc-hg.el, vc-mcvs.el, vc-rcs.el,
        vc-sccs.el, vc-svn.el: These now implement the NewVC-fileset.
        * vc.el: Adapted for NewVC-fileset, but no functional changes yet.

Older versions of the file have

    (insert "Working file): "  [...]

which is matched by log-view-file-re.


   Bernhard




reply via email to

[Prev in Thread] Current Thread [Next in Thread]