Re: 23.0.50; tool bar icons disappear in customize buffers

[Reiner Steib]

Hi,

I didn't get a response to this in ~4 weeks:


On Sat, Dec 08 2007, Reiner Steib wrote:

>> Please describe exactly what actions triggered the bug
>> and the precise symptoms of the bug:
>
> emacs -Q
>
> M-x customize-variable RET savehist-mode RET
>
> ==> All tool bar icons disappear.  The tool bar area and thus the
>     whole frame shrinks.
>
> ,----[ <f1> v tool-bar-map RET ]
> | tool-bar-map is a variable defined in `[...]/emacs/lisp/tool-bar.elc'.
> | Its value is shown below.
> | 
> | Documentation:
> | Keymap for the tool bar.
> | Define this locally to override the global tool bar.
> | 
> | Value: nil
> | Local in buffer *Customize Option: Savehist Mode*; global value is 
> | (keymap
> |  (new-file menu-item "Visit New File..." find-file
> | [...]
> `----
>
> ,----[ <f1> v tool-bar-mode RET ]
> | tool-bar-mode is a variable defined in `[...]/emacs/lisp/tool-bar.elc'.
> | Its value is t
> | 
> | Documentation:
> | Non-nil if Tool-Bar mode is enabled.
> | See the command `tool-bar-mode' for a description of this minor mode.
> | Setting this variable directly does not take effect;
> | either customize it (see the info node `Easy Customization')
> | or call the function `tool-bar-mode'.
> | 
> | You can customize this variable.
> `----
>
> I'd guess that the following changes might be relevant:
>
> ,----[ lisp/ChangeLog ]
> | 2007-07-05  Chong Yidong  <address@hidden>
> | 
> |     * cus-edit.el (custom-commands): New variable.
> |     (custom-tool-bar-map): New variable.  Initialize using
> |     `custom-commands'.
> |     (custom-mode): Use `custom-tool-bar-map'.
> |       [...]
> `----
>
> Is the following code in `cus-edit.el' correct?  Is this code
> evaluated at compile time (when `display-graphic-p' returns nil?)?
>
> (defvar tool-bar-map)
> (defvar custom-tool-bar-map
>   (if (display-graphic-p)
>       (let ((map (make-sparse-keymap)))
>       (mapc
>        (lambda (arg)
>          (tool-bar-local-item-from-menu
>           (nth 1 arg) (nth 4 arg) map custom-mode-map))
>        custom-commands)
>       map)))
>
> [BTW, using `when' would make the code more readable.  Shouldn't the
> variable have a doc string?]
>
> ,----[ <f1> v custom-tool-bar-map RET ]
> | custom-tool-bar-map is a variable defined in 
> `[...]/emacs/lisp/cus-edit.elc'.
> | Its value is nil
> | 
> | Documentation:
> | Not documented as a variable.
> `----
>
> The problem doesn't exist neither in Emacs 22.1 nor in EMACS_22_BASE.
>
>> In GNU Emacs 23.0.50.7 (i686-pc-linux-gnu, GTK+ Version 2.10.6)
>>  of 2007-12-08 on viandante
>> Windowing system distributor `The X.Org Foundation', version 11.0.70199902
>> configured using `configure '--prefix=/import/xtra/emacs/HEAD'
>>   '--with-gtk' '--exec-prefix=/import/xtra/emacs/HEAD-i686'
>>   'CFLAGS=-Wno-pointer-sign -O0 -fno-crossjumping -gdwarf-2 -g3''
>
>> Important settings:
>>   value of $LC_ALL: nil
>>   value of $LC_COLLATE: nil
>>   value of $LC_CTYPE: nil
>>   value of $LC_MESSAGES: nil
>>   value of $LC_MONETARY: nil
>>   value of $LC_NUMERIC: nil
>>   value of $LC_TIME: nil
>>   value of $LANG: en_US.UTF-8
>>   locale-coding-system: utf-8
>>   default-enable-multibyte-characters: t
>
>> Major mode: Custom
>
>> Minor modes in effect:
>>   tooltip-mode: t
>>   tool-bar-mode: t
>>   mouse-wheel-mode: t
>>   menu-bar-mode: t
>>   file-name-shadow-mode: t
>>   global-font-lock-mode: t
>>   font-lock-mode: t
>>   blink-cursor-mode: t
>>   unify-8859-on-encoding-mode: t
>>   utf-translate-cjk-mode: t
>>   auto-compression-mode: t
>>   line-number-mode: t
>
>> Recent input:
>> M-x c u s t o m i z w <backspace> e - v a r i a b e 
>> l <backspace> <backspace> l e <return> s a v e h i 
>> s t - m o d e <return> <f1> v t o o l 0 <backspace> 
>> - b a r - m a <tab> <return> C-x 2 <f1> v t o o l - 
>> b a r - m o d e <return> <help-echo> <help-echo> <down-mouse-2> 
>> <mouse-2> M-x r e p o <tab> r <tab> <return>
>
>> Recent messages:
>> For information about GNU Emacs and the GNU system, type C-h C-a.
>> Creating customization items...
>> Loading savehist...done
>> Creating customization items ...done
>> Resetting customization items...done
>> Creating customization setup...done
>> Type C-x 1 to delete the help window, C-M-v to scroll help.
>> Making completion list...