Re: Mode line changes

[Dan Nicolaescu]

Nick Roberts <address@hidden> writes:

  >  >   > 1) Toggling line and column display should move to mouse-3 as it's a
  >  >   >    convention the this button is used for pull down menus where 
possible.
  >  > 
  >  > mouse-1 on the mode-line pops both the major-mode and minor-mode menus.  
  > 
  > That's why I said "where possible".  Mouse-3 is tied up with other menus on 
the
  > major and minor modes.  Whereas mouse-3 currently on the line number mode 
does
  > nothing so I don't see the point in breaking the convention when there is no
  > need.

So you are arguing that for popping a menu one would have to use mouse-1
for the major-mode, vc-mode, and minor-modes and then when moving one
entry to the left use mouse-3 for the line-number/column-number menu ? 
That's completely inconsistent.  Adding a binding to mouse-3 would make
more sense if that's considered necessary.


  >  >   > 2) The size indication lighter shouldn't toggle line and column 
display
  >  >   >    because it has a different purpose.
  >  > 
  >  > Why not?
  > 
  > Because it's not intuitive and I guess it's bad UI design to have two 
buttons
  > next to each other that do the same thing.

Don't see why. Better do something useful than nothing. And it helps if
you manage to turn off both column-number-mode and line-number-mode,
it won't be easy to turn them back on.

  >  > 
  >  >   > 3) The mode-line-highlight should not be applied to mode-line-remote 
because
  >  >   >    this face is used for `buttons' and no local-map (binding) has 
been added
  >  >   >    here.
  >  > 
  >  > Yep, but if there's no highlighting you'd never know there's anything
  >  > special about that place on the mode-line if you don't keep the mouse
  >  > long enough for the tooltip to appear.
  > 
  > You have a point but you might just ask yourself why the symbol was there, 
in
  > the first place and then you would have to move the mouse over it to 
realise it
  > has mode-line-highlight anyway.  In any case, the hand icon appears where 
there
  > is mode-line-highlight, 

Well, I added that because I never noticed the tooltip until I saw the
corresponding code in bindings.el, and I did spend time looking at the
mode-line tooltips when I rewrote the text.  I don't really care that
much about this issue, so if you really don't like it, go ahead in
remove it.