[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patch to hilight-chg not in emacs 22.1
From: |
Stefan Monnier |
Subject: |
Re: patch to hilight-chg not in emacs 22.1 |
Date: |
Tue, 18 Mar 2008 12:51:32 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) |
>>> So, I have simplified the change to hilit-chg.el and have removed the
>>> part
>>> that required the change to easy-mmode. (I think what I was previously
>>> doing was overkill anyway.)
>>
>> Thank you, this looks good. I'd only advise you to rename
>> highlight-changes-toggle-visibility to highlight-changes-visible-mode
>> and define it (yet again) with define-minor-mode.
> So, if I understand it, you are suggesting having two minor modes:
> highlight-changes-mode and highlight-changes-visible-mode? Isn't that
> going to be a bit confusing??
> If highlight-changes-mode were on then the meaning of the new mode is
> straight forward, but if it were off should it just toggle the flag and
> otherwise have no effect? So it affects highlight changes mode either
> immediately if that mode is on otherwise the next time it is turned on?
> I can try and it see what it's like.
In what way are those problems different if the command is named
"highlight-changes-toggle-visibility" and implemented without
define-minor-mode?
Stefan
Re: patch to hilight-chg not in emacs 22.1, martin rudalics, 2008/03/18