emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 23.0.60; uid problems on w32


From: Eli Zaretskii
Subject: Re: 23.0.60; uid problems on w32
Date: Sat, 05 Apr 2008 18:12:39 +0300

> Date: Mon, 31 Mar 2008 15:28:15 +0100
> From: Jason Rumney <address@hidden>
> CC: address@hidden, address@hidden, 
>  address@hidden
> 
> Eli Zaretskii wrote:
> >> Eli Zaretskii wrote:
> >>     
> >>> Actually, one (in `struct passwd') is `signed int', the other (in
> >>> `struct stat') is `signed short'.  Darn that MS-supplied stat.h!
> >>>       
> >
> > OK, I will add this to my todo.  Thanks.
> >   
> 
> I have just checked in a hack to Ffile_attributes that casts the uid in 
> the stat structure to unsigned short on windows to make it consistent 
> with getuid.
> You'll need to remove this hack if/when you make the above more 
> comprehensive change.

You did that on the release branch.  I don't think we should begin
using our own sys/stat.h on the branch, so this change will probably
stay there.

We should probably backport to the branch another similar change in
dired.c, the one that forces inode numbers to be positive; it is now
only on the trunk.  Any objections?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]