Re: Maintenance suggestion on an emacs mode

[Lennart Borgman (gmail)]

Ralf Angeli wrote:
> * Stefan Monnier (2008-04-23) writes:
>
> > > Another option would be to remove those bindings altogether and put the
> > > code for defining the key bindings into the manual for easy copying and
> > > pasting into the init file.
> > Doesn't seem like an improvement,
>
> Then I'd suggest to just add a comment in reftex.el as proposed earlier
> in this thread.  

I suggested moving this to the defcustom instead (and of course updating 
its doc string). Is not that easier for the user?

> Following is a ChangeLog entry and patch.
>
>
> 2008-04-24  Ralf Angeli  <address@hidden>
>
>         * textmodes/reftex.el: Explain in a comment why
>         `reftex-extra-bindings' activates key bindings reserverd for
>         users.
>
>
> --- reftex.el.~1.86.~   2008-04-19 08:52:29.000000000 +0200
> +++ reftex.el   2008-04-24 22:19:18.000000000 +0200
> @@ -2403,7 +2403,10 @@
>   "bibtex"
>   '(define-key bibtex-mode-map "\C-c&" 'reftex-view-crossref-from-bibtex))
>  
> -;; If the user requests so, she can have a few more bindings:
> +;; For most of these commands there are already bindings in place.
> +;; Setting `reftex-extra-bindings' really is only there to spare users
> +;; the hassle of defining bindings in the user space themselves.  This
> +;; is why they violate the key binding recommendations.
>  (when reftex-extra-bindings
>    (loop for x in
>          '(("\C-ct" . reftex-toc)