[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adding parameters to windows
From: |
David Kastrup |
Subject: |
Re: Adding parameters to windows |
Date: |
Wed, 04 Jun 2008 13:18:49 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) |
address@hidden writes:
> Stefan Monnier <address@hidden> writes:
>
>> Your patch needs a few tweaks, e.g. to adjust it to the coding
>> conventions:
>> - The docstring of window-parameters is poor.
>> E.g. the first line doesn't say anything. The second line is indented
>> in the source, which looks bad when you do C-h f window-parameters.
>> nil is an aliast as well, so there's no need to mention it explicitly.
>> - I'd prefer to have `window-parameter' rather than `window-parameters'.
>> - The docstring of set-window-parameter needs to start with a capital
>> letter and end with a "." and should mention its arguments.
>> Feel free to plagiarize set-frame-parameter.
>> - The comment for window_parameters refers to `pin' and `group'.
>
> I've tried to adress your concerns in the attached patch.
M-x checkdoc RET
should help with getting stuff more coding convention compliant.
--
David Kastrup
- Re: Adding parameters to windows, joakim, 2008/06/04
- Re: Adding parameters to windows,
David Kastrup <=
- Re: Adding parameters to windows, Stefan Monnier, 2008/06/04
- Re: Adding parameters to windows, Juanma Barranquero, 2008/06/04
- Re: Adding parameters to windows, Juanma Barranquero, 2008/06/04
- Re: Adding parameters to windows, joakim, 2008/06/04
- Re: Adding parameters to windows, Juanma Barranquero, 2008/06/04
- Re: Adding parameters to windows, joakim, 2008/06/04