emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Window-groups


From: Richard M Stallman
Subject: Re: [PATCH] Window-groups
Date: Mon, 23 Jun 2008 10:14:40 -0400

    +(defun window-group-create (window)
    +  "Return a window group object with WINDOW as its only member.
    +An error is signalled if WINDOW is not visible or already part of
    +a group."

That's ambiguous -- it is not clear whether "not" covers the second
disjunct.  I suggest "...is not visible or if it is already..."

Also, "An error is signalled" is passive.  Please try to stick to the
active voice whenever that isn't difficult to do.

    +The windows in the group are not deleted."

More passive voice.  It will be clearer if you make it active.

    +;; Here's some examples.

"Here are".

    +(defun window-group-members (group)
    +  "Return all windows in GROUP.
    +Must be in selected frame."

That last sentence is very vague.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]