fix pop snarfing on Windows Rmail

[John Paul Wallington]

I have a Windows machine where Rmail is configured like this:

(setq rmail-primary-inbox-list '("po:user:localhost"))
(setq rmail-remote-password-required t)
(setq rmail-remote-password "password")

and it didn't work to get any mail from the pop server.

Looks like this patch is needed:

2008-08-20  John Paul Wallington  <address@hidden>

        * mail/rmail.el (rmail-insert-inbox-text): Ensure that the
        filename of `tofile' doesn't contain any colons on Windows
        and Cygwin systems.

Index: rmail.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/mail/rmail.el,v
retrieving revision 1.454
diff -u -r1.454 rmail.el
--- rmail.el    6 May 2008 07:22:26 -0000       1.454
+++ rmail.el    20 Aug 2008 22:22:51 -0000
@@ -1804,8 +1804,8 @@
                    (concat ".newmail-"
                            (file-name-nondirectory
                             (if (memq system-type '(windows-nt cygwin))
-                                ;; cannot have "po:" in file name
-                                (substring file 3)
+                                ;; cannot have colons in file name
+                                (replace-regexp-in-string ":" "-" file)
                               file)))
                    ;; Use the directory of this rmail file
                    ;; because it's a nuisance to use the homedir

I'll install it in a few days unless someone objects.