emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tooltip-mode shouldn't be enabled in the Linux console by default


From: Nick Roberts
Subject: Re: tooltip-mode shouldn't be enabled in the Linux console by default
Date: Tue, 28 Apr 2009 19:57:18 +1200

 > > And if not applicable, what should it do, in your opinion?
 > 
 > Show the tip in the echo area, as though tooltip-mode were off.  I've
 > checked in a fix to CVS.

I would prefer that you posted the patch to the mailing list first.  This
looks to me like an ugly hack that subverts the purpose of
tooltip-show-help-non-mode.  I tried the patch below (against 1.93, the
version before your checkin) but the help message seems to persist after the
mouse has moved away from the mouse-highlight region.  In any case, I think
the patch should make use of the use-echo-area argument of tooltip-show.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


*** /home/nickrob/emacs/lisp/tooltip.el.~1.93~  2009-04-28 19:24:26.000000000 
+1200
--- /home/nickrob/emacs/lisp/tooltip.el 2009-04-28 19:42:47.000000000 +1200
*************** This is installed on the hook `tooltip-f
*** 375,382 ****
  is run when the timer with id `tooltip-timeout-id' fires.
  Value is non-nil if this function handled the tip."
    (when (stringp tooltip-help-message)
!     (tooltip-show tooltip-help-message tooltip-use-echo-area)
!     t))
  
  (provide 'tooltip)
  
--- 375,382 ----
  is run when the timer with id `tooltip-timeout-id' fires.
  Value is non-nil if this function handled the tip."
    (when (stringp tooltip-help-message)
!     (tooltip-show tooltip-help-message
!                 (or (not (display-graphic-p)) tooltip-use-echo-area))  t))
  
  (provide 'tooltip)
  





reply via email to

[Prev in Thread] Current Thread [Next in Thread]