emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Suspicious code


From: Stefan Monnier
Subject: Suspicious code
Date: Wed, 28 Oct 2009 15:08:44 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux)

Can anyone fix the code below or add comments explaining why
it's correct?

Thank you,


        Stefan


--- lisp/gnus/gnus-start.el     9 Jan 2009 03:01:50 -0000       1.65
+++ lisp/gnus/gnus-start.el     28 Oct 2009 18:47:33 -0000
@@ -3058,6 +3041,7 @@
       nil)
      (t
       (save-excursion
+        ;; Shouldn't we set-buffer before saving the restriction?  --Stef
        (save-restriction
          (set-buffer nntp-server-buffer)
          (goto-char (point-min))

--- lisp/gnus/gnus-uu.el        5 Jan 2009 03:22:06 -0000       1.36
+++ lisp/gnus/gnus-uu.el        28 Oct 2009 18:47:36 -0000
@@ -873,10 +869,11 @@
        (set-buffer "*gnus-uu-body*")
        (goto-char (setq beg (point-max)))
        (save-excursion
+          ;; Shouldn't we set-buffer before saving the restriction?  --Stef
          (save-restriction
            (set-buffer buffer)
            (let (buffer-read-only)
@@ -1983,6 +1966,7 @@
                  (gnus-uu-choose-action file-name gnus-uu-ext-to-mime-list)
                  file-name))
   (insert (format "Content-Transfer-Encoding: %s\n\n" encoding))
+  ;; Shouldn't we set-buffer before saving the restriction?  --Stef
   (save-restriction
     (set-buffer gnus-message-buffer)
     (goto-char (point-min))




reply via email to

[Prev in Thread] Current Thread [Next in Thread]