emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: compilation-process-setup-function doc bug?


From: Stefan Monnier
Subject: Re: compilation-process-setup-function doc bug?
Date: Wed, 04 Nov 2009 21:44:44 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux)

>> Indeed, it appears the doc disagrees with the code.
>> I'm not sure when the problem appeared, but the `compilation-buffer' is
>> (current-buffer).  OTOH compilation-window is not
>> immediately available.  (get-buffer-window (curent-buffer) 0) will
>> usually return the right window, tho.

> In that case I'd be happy to fix the code by making both variables buffer
> local to the compilation buffer thus making the documentation consistent.
> Unless you would prefer to have the last sentence removed from the
> description and leave it to the User to figure out how to get the buffer or
> window should they need it.  My preference is the former.

Since this behavior has been present since at least Emacs-22, I'd just
remove the sentence from the docstring: (current-buffer) is a very good
way to pass a buffer argument.  As for the window, if we really want to
pass it, then we should just select it during that call, but I don't
think it's worth the trouble.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]