[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Warning when byte-compiling simple.el
From: |
Stefan Monnier |
Subject: |
Re: Warning when byte-compiling simple.el |
Date: |
Fri, 13 Nov 2009 09:50:38 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) |
> In minibuffer-default-add-completions:
> simple.el:1375:15:Warning: all-completions called with 4 arguments, but
> accepts only 2-3
> This warning is a lie: all-completions accepts 2 to 4 arguments. I
> don't think we should lie about that; if we want to deprecate the 4th
> argument, we should find a better way of conveying this to its users.
I guess the warning should use a more informative message, indeed.
> In any case, we shouldn't call it with 4 arguments ourselves,
> certainly not in such a core file as simple.el.
Agreed. So the warning worked: it caught this use ;-)
Stefan