Re: bookmark.el bug report

[Thierry Volpiatto]

Karl Fogel <address@hidden> writes:

> Sun Yijiang <address@hidden> writes:
>> `bookmark-bmenu-execute-deletions' is broken for quite some time.  I
>> think I've found the problem.  When it calls
>> `bookmark-bmenu-bookmark', the callee gets text property at
>> `(line-begging-position)', which is incorrect in this context.  Below
>> is the patched code of  `bookmark-bmenu-bookmark' that works for me:
>>
>> (defun bookmark-bmenu-bookmark ()
>>   "Return the bookmark for this line in an interactive bookmark list buffer."
>>   (when (bookmark-bmenu-check-position)
>>     (let ((pos (line-beginning-position)))
>>       (when (looking-back "^[^ ]")
>>         (setq pos (+ 1 pos)))
>>       (get-text-property pos 'bookmark-name-prop))))
>
> Thank you -- I will take a look!

Consider using the definition of bookmark-extensions.el:
(That's what i sent in original patch for bookmark.el)

(defun bookmark-bmenu-bookmark ()
  "Return the name of the bookmark on this line."
  (when (bookmark-bmenu-check-position)
    (save-excursion
      (forward-line 0) (forward-char 3)
      (get-text-property (point) 'bmkext-bookmark-name))))



-- 
A + Thierry Volpiatto
Location: Saint-Cyr-Sur-Mer - France