emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-21.1.94 crash in gnus on Windows


From: Chong Yidong
Subject: Re: emacs-21.1.94 crash in gnus on Windows
Date: Wed, 24 Mar 2010 17:34:14 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.94 (gnu/linux)

Andreas Schwab <address@hidden> writes:

> This is fundamentally broken.  move_it_to never produces glyphs, so the
> complete glyph row is uninitialized.  This was first broken by this
> change:
>
> commit 9d73ed0ef33ba0502c03e546a09d175ab35fdc75
> Author: Chong Yidong <address@hidden>
> Date:   Sat Jan 26 01:00:44 2008 +0000
>
>     (pos_visible_p): Handle the case where charpos falls on
>     invisible text covered with an ellipsis.

Yes, this patch is wrong.  Looking through the archives, it seems to
have been meant to address the problem at

  http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00945.html

However, looking at that recipe, it seems the problem is actually
handled by my 2009-01-10 (it_method == GET_FROM_DISPLAY_VECTOR) change
instead.  So either my 2008-01-26 change was bogus all along, or some
other change in the meantime made it bogus.

I've reverted it in the branch; thanks for investigating.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]