emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99824: 2010-04-04 John Wiegley


From: Juanma Barranquero
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99824: 2010-04-04 John Wiegley <address@hidden>
Date: Wed, 14 Apr 2010 13:50:58 +0200

I'm not sure the virtual buffers behavior makes much sense for
ido-kill-buffer. You cannot "kill" nonexistent buffers, you *don't*
want to kill the file, and you cannot kill the entry from the buffer
list.

So, I think either the following patch should be installed (plus
changes to a few docstrings, of course) or ido-kill-buffer "fixed" to
remove the nonbuffer entry from the buffer list. The problem with that
second option is that, to work right, it should either modify the
recentf list (which would likely be surprising to the user), or jump a
few hoops to maintain a list of buffers killed from the ido list but
still present into the recentf list. A bit hackish for so short a
reward, IMHO.

    Juanma


=== modified file 'lisp/ido.el'
--- lisp/ido.el 2010-04-06 18:17:55 +0000
+++ lisp/ido.el 2010-04-14 11:40:45 +0000
@@ -4078,5 +4078,6 @@
 For details of keybindings, see `ido-switch-buffer'."
   (interactive)
-  (ido-buffer-internal 'kill 'kill-buffer "Kill buffer: "
(buffer-name (current-buffer)) nil 'ignore))
+  (let (ido-use-virtual-buffers)
+    (ido-buffer-internal 'kill 'kill-buffer "Kill buffer: "
(buffer-name (current-buffer)) nil 'ignore)))

 ;;;###autoload




reply via email to

[Prev in Thread] Current Thread [Next in Thread]