[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Buffer size limitation in insdel.c
From: |
Eli Zaretskii |
Subject: |
Re: Buffer size limitation in insdel.c |
Date: |
Thu, 23 Sep 2010 21:22:02 +0200 |
> From: Lars Magne Ingebrigtsen <address@hidden>
> Date: Thu, 23 Sep 2010 21:02:04 +0200
>
> Eli Zaretskii <address@hidden> writes:
>
> > Maybe try this on the files I modified today, to see how many problems
> > I missed. (I tried this with GCC 4.2.4, but got zero matches from
> > egrep, probably because the output format of -Wconversion is
> > completely different.
>
> Let's see...
>
> Here's intervals.c:
>
> intervals.c:1938: warning: conversion to 'int' from 'long int' may alter its
> value
> intervals.c:1961: warning: conversion to 'int' from 'long int' may alter its
> value
>
> Almost totally clean.
Thanks, fixed. It was due to return value of a single function.
> editfns.c, however:
>
> make -k 2>&1 | egrep "conversion.*'int'.*(Lisp_Ob|long)"
> editfns.c:279: warning: conversion to 'int' from 'long int' may alter its
> value
> editfns.c:281: warning: conversion to 'int' from 'long int' may alter its
> value
> editfns.c:283: warning: conversion to 'int' from 'long int' may alter its
> value
> editfns.c:825: warning: conversion to 'int' from 'long int' may alter its
> value
> editfns.c:997: warning: conversion to 'int' from 'long int' may alter its
> value
> editfns.c:1012: warning: conversion to 'int' from 'long int' may alter its
> value
> editfns.c:1533: warning: conversion to 'int' from 'Lisp_Object' may alter its
> value
> editfns.c:1683: warning: conversion to 'int' from 'long int' may alter its
> value
> editfns.c:1807: warning: conversion to 'int' from 'Lisp_Object' may alter its
> value
> editfns.c:1808: warning: conversion to 'int' from 'Lisp_Object' may alter its
> value
Only the first 3 are related to buffer and string positions (again,
return value of a single function); I fixed them. The rest are
unrelated: they are about SPECPDL_INDEX and time values.
Thanks.
- Re: Buffer size limitation in insdel.c, (continued)
- Re: Buffer size limitation in insdel.c, Eli Zaretskii, 2010/09/23
- Re: Buffer size limitation in insdel.c, Lars Magne Ingebrigtsen, 2010/09/23
- Re: Buffer size limitation in insdel.c, Eli Zaretskii, 2010/09/23
- Re: Buffer size limitation in insdel.c, Lars Magne Ingebrigtsen, 2010/09/23
- Re: Buffer size limitation in insdel.c, Lars Magne Ingebrigtsen, 2010/09/23
- Re: Buffer size limitation in insdel.c, Eli Zaretskii, 2010/09/23
- Re: Buffer size limitation in insdel.c, Lars Magne Ingebrigtsen, 2010/09/23
- Re: Buffer size limitation in insdel.c, Lars Magne Ingebrigtsen, 2010/09/23
- Re: Buffer size limitation in insdel.c, Eli Zaretskii, 2010/09/23
- Re: Buffer size limitation in insdel.c, Lars Magne Ingebrigtsen, 2010/09/23
- Re: Buffer size limitation in insdel.c,
Eli Zaretskii <=
- Re: Buffer size limitation in insdel.c, Richard Stallman, 2010/09/24
- Re: Buffer size limitation in insdel.c, Eli Zaretskii, 2010/09/24
- Re: Buffer size limitation in insdel.c, Lars Magne Ingebrigtsen, 2010/09/24
- Re: Buffer size limitation in insdel.c, Eli Zaretskii, 2010/09/25
- Re: Buffer size limitation in insdel.c, Lars Magne Ingebrigtsen, 2010/09/25
- Re: Buffer size limitation in insdel.c, Lars Magne Ingebrigtsen, 2010/09/25
- Re: Buffer size limitation in insdel.c, Richard Stallman, 2010/09/25
- Re: Buffer size limitation in insdel.c, Eli Zaretskii, 2010/09/25