[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Emacs-diffs Digest, Vol 94, Issue 89
From: |
Eli Zaretskii |
Subject: |
Re: Emacs-diffs Digest, Vol 94, Issue 89 |
Date: |
Fri, 24 Sep 2010 21:00:29 +0200 |
> === modified file 'src/scroll.c'
> --- a/src/scroll.c 2010-07-12 17:47:17 +0000
> +++ b/src/scroll.c 2010-09-24 15:20:58 +0000
> @@ -94,7 +94,7 @@
> int free_at_end)
> {
> register int i, j;
> - int frame_lines = FRAME_LINES (frame);
> + EMACS_INT frame_lines = FRAME_LINES (frame);
Is this really a good idea? There's no chance the number of lines in
a frame will overflow a 32-bit int any time soon. SO I think an
explicit cast to int is a better solution here.
(There are other similar places in this revision.)
- Re: Emacs-diffs Digest, Vol 94, Issue 89,
Eli Zaretskii <=
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Lars Magne Ingebrigtsen, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Eli Zaretskii, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Eli Zaretskii, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, David Kastrup, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Eli Zaretskii, 2010/09/25
- Re: Emacs-diffs Digest, Vol 94, Issue 89, David Kastrup, 2010/09/25
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Chong Yidong, 2010/09/24
- Re: Emacs-diffs Digest, Vol 94, Issue 89, Stefan Monnier, 2010/09/25
Re: Emacs-diffs Digest, Vol 94, Issue 89, Stefan Monnier, 2010/09/24