[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101633: Add fd handling with cal
From: |
Eli Zaretskii |
Subject: |
Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101633: Add fd handling with callbacks to select, dbus needs it for async operation. |
Date: |
Sun, 26 Sep 2010 21:17:46 +0200 |
> Date: Sun, 26 Sep 2010 21:07:32 +0200
> From: Jan Djärv <address@hidden>
> CC: address@hidden
>
> > The changes that remove the "#ifdef subprocesses" conditionals will
> > probably break the MSDOS build, because input_wait_mask etc. are only
> > defined "#ifdef subprocesses". The functions
> > add_keyboard_wait_descriptor and delete_keyboard_wait_descriptor are
> > supposed to be no-ops for the MSDOS build.
>
> We need another ifdef then as dbus and for example session file descriptors
> have nothing to do with subprocesses. #ifndef MSDOS perhaps?
The only Emacs build that doesn't have `subprocesses' #define'd is the
MSDOS build. Using "#ifdef subprocesses" is just slightly less ugly
then OS-dependent #define, but otherwise it is functionally identical
to "#ifndef MSDOS".
So I don't think we need another ifdef.