[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#7234: 24.0.50; strange message after text-scale-adjust
From: |
Stefan Monnier |
Subject: |
Re: bug#7234: 24.0.50; strange message after text-scale-adjust |
Date: |
Tue, 19 Oct 2010 12:26:55 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
>> > It would be better that read-event call in
>> > text-scale-adjust has some prompt:
>> > e.g. (read-event "+,-,0 for further adjustment: ")
>> Agreed.
> Shall I install that change, or do you have a better prompt
> string, or should we wait for your alternative
> implementation?
Go ahead with your change. It's not directly related to my alternative
implementation anyway and that implementation is still work in progress.
>> > For non-interactive use, you should probably also be using
>> > `text-scale-set' or `text-scale-increase' instead.
>> BTW, I've been playing around with an alternative implementation for
>> such things. The reason is that the use of
>> read-event/read-char/read-key has surprising side-effects: in those
>> cases I'm concerned with, the user expects that the command is already
>> finished and the behavior is somewhat consistent with that expectation,
>> but not completely: indeed typing "any" key sequence (except for a few
>> special ones) runs the usual corresponding command, but OTOH
>> post-command-hook and friends aren't run when expected.
> I think the situation is similar to isearch. How does
> isearch solve it?
isearch uses an overlay map (overriding-terminal-local-map) rather than
read-key/event/char.
> With that, how to show the prompt?
You'd do it with `message'.
Stefan