Re: running ./temacs

[Dan Nicolaescu]

Eli Zaretskii <address@hidden> writes:

>> From: Dan Nicolaescu <address@hidden>
>> Date: Thu, 18 Nov 2010 17:19:13 -0500
>> Cc: address@hidden
>> 
>> Stefan Monnier <address@hidden> writes:
>> 
>> >>>>> [Hacking around this so that Vprocess_environment is initialized when
>> >>>>> not dumping makes ./temacs work correctly]
>> >>>> In case anyone wants to see the difference in behavior, here's the
>> >>>> ugly hack:
>> >>> Could you explain your code (i.e. why you need those strcmp hacks, why
>> >>> you need to set&unset initialized, ...)?
>> >> set_initial_environment only initializes Vprocess_environment if
>> >> `initialized' is set.
>> >
>> > Do you happen to know why?
>> 
>> No idea.  I'd speculate that it's undesirable to initialize it when 
>> dumping...
>
> Yes, probably.
>
> I'd think it's cleaner to add an argument to set_initial_environment,
> which then could tell it whether to initialize Vprocess_environment,
> instead of intuiting that inside the function by looking at
> `initialized' and CANNOT_DUMP.  We could then set that argument
> non-zero when temacs is run with arguments other than "dump" or
> "bootstrap".

Agreed.
Also, if we get ./temacs to work correctly then a lot of #ifdef
CANNOT_DUMP code can be reconsidered.  After all running just ./temacs
is very close to running with CANNOT_DUMP defined.

Things like:
  if (1
#ifndef CANNOT_DUMP
      && initialized
#endif
      )

might not be needed at all...