[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] GnuTLS support on Woe32
From: |
Claudio Bley |
Subject: |
Re: [PATCH] GnuTLS support on Woe32 |
Date: |
Wed, 23 Mar 2011 21:50:59 +0100 |
User-agent: |
Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/23.1 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
At Tue, 22 Mar 2011 01:40:06 -0400,
Stefan Monnier wrote:
> > +#ifdef HAVE_GNUTLS
> > + /* GnuTLS buffers data internally. In lowat mode it leaves some
> > data
>
> Shouldn't that be "Iowait"?
No, it's a "low water" value / mode. Whatever that's supposed to
mean...
> Also please put 2 spaces after a ".".
>
> > + && gnutls_record_check_pending(wait_proc->gnutls_state) > 0)
> ^^
> needs a space
>
> > + sc = select (fd + 1, &fdset, (SELECT_TYPE *)0, (SELECT_TYPE
> > *)0, &timeout);
>
> That seems to go way past column 80. Please fold it.
>
> > + /* translate WSAEWOULDBLOCK alias
> > + EWOULDBLOCK to EAGAIN for
> > + GnuTLS */
>
> The comment above needs to start with a capital letter and end with a ".".
>
> > +extern ssize_t emacs_gnutls_pull(gnutls_transport_ptr_t p,
> > + void* buf, size_t sz);
> > +extern ssize_t emacs_gnutls_push(gnutls_transport_ptr_t p,
> > + const void* buf, size_t sz);
>
> Again, the above needs spaces before the open paren.
OK, is there a style guide somewhere or better yet a style checker for
these kind of faux pas?
- Claudio
- Re: [PATCH] GnuTLS support on Woe32, (continued)
- Re: [PATCH] GnuTLS support on Woe32, Ted Zlatanov, 2011/03/23
- Re: [PATCH] GnuTLS support on Woe32, Stefan Monnier, 2011/03/23
- Re: [PATCH] GnuTLS support on Woe32, Ted Zlatanov, 2011/03/23
- Re: [PATCH] GnuTLS support on Woe32, Stefan Monnier, 2011/03/23
- Re: [PATCH] GnuTLS support on Woe32, Claudio Bley, 2011/03/23
- Re: [PATCH] GnuTLS support on Woe32, Ted Zlatanov, 2011/03/24
- Re: [PATCH] GnuTLS support on Woe32, Robert Pluim, 2011/03/24
- Re: [PATCH] GnuTLS support on Woe32, Ted Zlatanov, 2011/03/24
- Re: [PATCH] GnuTLS support on Woe32, Robert Pluim, 2011/03/25
- Re: [PATCH] GnuTLS support on Woe32, Ted Zlatanov, 2011/03/25
- Re: [PATCH] GnuTLS support on Woe32,
Claudio Bley <=
- Re: [PATCH] GnuTLS support on Woe32, Stefan Monnier, 2011/03/23
- GNU coding standard highlighting rules (was: [PATCH] GnuTLS support on Woe32), Ted Zlatanov, 2011/03/24
- Re: GNU coding standard highlighting rules, Stefan Monnier, 2011/03/27
- Re: GNU coding standard highlighting rules, Ted Zlatanov, 2011/03/28
- Re: [PATCH] GnuTLS support on Woe32, Ted Zlatanov, 2011/03/23
- Re: [PATCH] GnuTLS support on Woe32, Eli Zaretskii, 2011/03/07
- Re: [PATCH] GnuTLS support on Woe32, Robert Pluim, 2011/03/07
Re: [PATCH] GnuTLS support on Woe32, Lars Magne Ingebrigtsen, 2011/03/07