Re: mail-add-attachment

[Eli Zaretskii]

> From: Stefan Monnier <address@hidden>
> Cc: address@hidden
> Date: Fri, 09 Sep 2011 10:32:19 -0400
> 
> > Is it okay to install this command at this time?  I know we're in a
> > feature freeze, but the new command is actually a very thin wrapper
> > around code we already use elsewhere (gnus-dired.el and mml.el).  The
> > result will be that users of sendmail.el will be able to send MIME
> > attachments.  Here's the patch:
> 
> I guess it could be OK.

Thanks, committed as revision 105699 on the trunk.

> > +(autoload 'mm-default-file-encoding "mm-encode"
> > +  "Return the default encoding for FILE.")
> 
> I must say I don't like such manually-managed autoloads.

I added autoload cookies to the relevant Gnus files instead, per the
suggestion by Andreas.

> > +\\[mail-attach-file] insert a text file into the message.
> > +\\[mail-add-attachment] add to the message a file as a MIME attachment.
> 
> I think mail-attach-file needs to be renamed to mail-insert-file.

Done.