Re: OAuth2 implementation in Elisp

[Julien Danjou]

On Sun, Sep 25 2011, Ted Zlatanov wrote:

> If you could stay under 78 it would be polite.  I can't find the
> reference but I'm pretty sure for Emacs submissions at least it's
> required.

Fine.

> #+begin_src lisp
>   (browse-url (concat auth-url
>                       (if (string-match-p "\?" auth-url) "&" "?")
>                       "client_id=" client-id
>                       
> "&response_type=code&redirect_uri=urn:ietf:wg:oauth:2.0:oob"
>                       (if scope (concat "&scope=" (url-hexify-string scope)) 
> "")
>                       (if state (concat "&state=" state) "")))
>
> #+end_src
>
> This is not a POST and `client_id' for instance could have invalid
> characters for a URL.

Good catch indeed. I'll do a re-check of such things then and will fix
them before they break. :-)

> That makes no sense.  You are asking the user to enter information Emacs
> is displaying.  Can you grab that information for them, so they don't
> have to enter it?

No, this would kill the whole point of OAuth. You may want to take a
look at the spec of the protocol to understand how it works. :)

-- 
Julien Danjou

pgpyh5ImqCaMH.pgp
Description: PGP signature