Re: /etc/TODO: define-minor-mode & minor-mode-list

[William Stevenson]

Stefan Monnier <address@hidden> writes:

>> Also is this todo considered todone?
>
> Largely, yes.  I did this during the Emacs-24 development (which lead to
> the addition of the `:variable' argument).  My methodology to find
> potential minor modes was to grep for something like "defun.*-mode
> ([^)]" since traditionally minor modes take an argument, whereas major
> modes don't.  There are a few cases I found which I haven't converted,
> usually because the conversion was less straightforward so I left it
> for later.  These are: orgstruct++-mode, tcl-auto-fill-mode,
> vhdl-hs-minor-mode, speedbar-frame-mode, reftex-isearch-minor-mode,
> type-break-mode.
> There are probably other candidates, of course.


I searched for more but I've probably unearthed more false positives
than anything else. I'll hopefully have at least one patch by the end of
the week.



| file                    | mode name                             | d-m-m | 
d-d-m | notes |
|-------------------------+---------------------------------------+-------+-------+-------|
| org/org.el              | orgstruct++-mode                      | y     |     
  |       |
| progmodes/tcl.el        | tcl-auto-fill-mode                    | y     |     
  |       |
| speedbar.el             | speedbar-frame-mode                   |       |     
  | ?     |
| reftex-global.el        | reftex-isearch-minor-mode             | y     |     
  | ?     |
| progmodes/vhdl-mode.el  | vhdl-hs-minor-mode                    | y     |     
  | ?     |
| textmodes/two-column.el | 2C-mode                               | y     |     
  |       |
| textmodes/artist.el     | artist-mode                           | y     |     
  |       |
| emulation/edt.el        | edt-select-mode                       |       |     
  | m/M?  |
| ehelp.el                | electric-help-orig-major-mode         | y     |     
  | ?     |
| eshell/esh-mode.el      | eshell-mode                           |       |     
  | m/M?  |
| textmodes/fill.el       | fill-indent-according-to-mode         | ?     | ?   
  |       |
| font-lock.el            | font-lock-major-mode                  | ?     | ?   
  |       |
| gnus/gnus-agent.el      | gnus-agent-mode                       | y     |     
  |       |
| gnus/gnus-start.el      | gnus-slave-mode                       | y     |     
  | FIXME |
| gnus/gnus-topic.el      | gnus-topic-mode                       | y     |     
  | FIXME |
| ido.el                  | ido-mode                              | y     |     
  |       |
| image-mode.el           | image-mode                            |       | y   
  |       |
| info-look.el            | info-lookup-mode                      |       |     
  | ?     |
| jit-lock.el             | jit-lock-mode                         | y     |     
  | ?     |
| avoid.el                | mouse-avoidance-mode                  | y     |     
  | ?     |
| net/rcirc.el            | rcirc-mode                            |       | y   
  | FIXME |
| nxml/rng-valid.el       | rng-validate-mode                     | y     |     
  |       |
| international/robin.el  | robin-mode                            |       |     
  | m/M?  |
| shell.el                | shell                                 |       |     
  | m/M?  |
| term.el                 | term-insert-mode                      |       |     
  | ?     |
| type-break.el           | type-break-mode                       | y     |     
  |       |
| uniquify.el             | uniquify-list-buffers-directory-modes |       |     
  | ?     |
| emulation/vi.el         | vi-mode-old-major-mode                |       | y   
  | old?  |
| winner.el               | winner-mode                           | y     |     
  |       |
|-------------------------+---------------------------------------+-------+-------+-------|