[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Evil defvars in org.el

From: Stefan Monnier
Subject: Re: Evil defvars in org.el
Date: Wed, 09 May 2012 13:37:51 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)

>> org.el (and org-agenda.el, and maybe others) have defvars like this:
>> (defvar entry)
>> (defvar date)
>> This is going to blow up in someone's face, because it makes `entry' and
>> `date' unusable as lexical variables, even though those are very common
>> variable names.  That is to say, loading Org mode would change the
>> behavior of packages using lexical binding in some unpredictable way.
>> Why does org need to do this?  Could you try to clean it up?

> Perhaps Emacs can prefix the `evil vars' and alias them to the original,
> with a deprecation warning?

Oh, no, no, please no, if you alias them then they become globally
"dynamic vars", whereas currently they're only dynamic vars within the
files that do (defvar entry) so the damage is somewhat contained.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]