Re: Using glib's g_file_monitor_file and g_file_monitor_directory

[Michael Albinus]

Jan Djärv <address@hidden> writes:

> Hello.

Hi,

>> I've committed a patch to the trunk which prevents this crash. However,
>> if you call "emacs -nw", you won't get any notification. I suppose we
>> need an generalized g_main_loop integration, synchronized with the code
>> in gtkutil.c.
>> 
>> Likely, we must move this code out of gtkutil.c and gfilenotify.c. Jan?
>
>
> Which code?  The glib event loop integration is in xgselect.c.  I
> think it is called in the -nw case also.  It is only dependent on
> HAVE_GLIB.
> The Gtk+ event loop integration is in xterm.c, it is a separate thing.

I was thinking about the g_main_loop_run and g_main_loop_quit calls in
gtkutil.c. Reading the code in more detail, it looks like the calls have
a local scope only, so we don't need to sync.

gfilenotify.c needs a running glib event loop. If Emacs is called with
the "-nw" flag there is no such event loop; it must be started in a new
thread by gfilenotify.c I believe.

>       Jan D.

Best regards, Michael.