Re: code review request for saveplace with dired buffer

[Glenn Morris]

Ivan Kanis wrote:

> +2013-06-99 Ivan Kanis <address@hidden>
> +     Add support for dired in saveplace.
> +     * dired.el (dired-initial-position-hook): New variable.

Add blank line before "Add support".

> + (save-place-position-dired-cursor): Move cursor in dired from previous 
> position.

You can simply say "New function". "New function to move..." if you prefer.
As has been pointed out, "point" is better than "cursor", in function
names as well as doc.

> +(defcustom dired-initial-position-hook nil
> +  "This hook is used to position the cursor position."
> +  :group 'dired
> +  :type 'hook)

Add :version "24.4".

I'd find a comment in the doc "Run by the function `dired-initial-position'."
helpful. And likewise in the doc of `dired-initial-position': "Runs the
hook `dired-initial-position-hook'."