Re: bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

[Claudio Bley]

At Tue, 11 Jun 2013 08:52:30 -0400,
Stefan Monnier wrote:
> 
> > 453    (defconst lisp--prettify-symbols-alist
> > 454      '(("lambda"  . ?λ)))
> 
> > Obviously because emacs reads the file with cp1152 by default instead
> > of UTF-8.
> 
> I think I just fixed it on the trunk.

Thanks, works for me.

> > *** No rule to make target `lisp/emacs-lisp/lisp-mode.elc' needed by `DOC'.
> > Shouldn't the compile rules exit early when byte compilation fails?
> 
> Yes (modulo "make -k" obviously).

OK, how about

---------------- 8< --------------- 8< --------------------------
diff --git a/lisp/makefile.w32-in b/lisp/makefile.w32-in
index f4bbaf3..6c1a49c 100644
--- a/lisp/makefile.w32-in
+++ b/lisp/makefile.w32-in
@@ -298,12 +298,12 @@ TAGS-LISP-SH: $(lisptagsfiles1) $(lisptagsfiles2) 
$(lisptagsfiles3) $(lisptagsfi
 
 TAGS-CMD: $(lisptagsfiles1) $(lisptagsfiles2) $(lisptagsfiles3) 
$(lisptagsfiles4)
        - $(DEL) TAGS
-       for %%d in (. $(WINS_UPDATES)) do $(ETAGS) -a $(lisp)/%%d/*.el
+       for %%d in (. $(WINS_UPDATES)) do ( $(ETAGS) -a $(lisp)/%%d/*.el || 
exit 1 )
 
 TAGS-LISP-CMD: $(lisptagsfiles1) $(lisptagsfiles2) $(lisptagsfiles3) 
$(lisptagsfiles4)
        - $(DEL) $(DEST)/TAGS-LISP
        for %%d in (. $(WINS_UPDATES)) do \
-         $(ETAGS) -a -o $(DEST)/TAGS-LISP $(lisp)/%%d/*.el
+         ( $(ETAGS) -a -o $(DEST)/TAGS-LISP $(lisp)/%%d/*.el || exit 1 )
 
 .SUFFIXES: .elc .el
 
@@ -328,29 +328,29 @@ compile: $(lisp)/subdirs.el compile0-$(SHELLTYPE) 
compile1-$(SHELLTYPE) compile2
 compile0-CMD: autoloads
 #      -for %%f in ($(lisp) $(WINS)) do for %%g in (%%f\*.elc) do @attrib -r 
%%g
        for %%f in ($(COMPILE_FIRST)) do \
-         $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done %%f
+         $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done %%f || exit 1
 
 compile1-CMD: autoloads compile0-CMD
        for %%f in (. $(WINS_BASIC1)) do for %%g in (%%f/*.el) do \
-         $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done %%f/%%g
+         ( $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done %%f/%%g || exit 1 )
 
 compile2-CMD: autoloads compile0-CMD
        for %%f in ($(WINS_BASIC2)) do for %%g in (%%f/*.el) do \
-         $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done %%f/%%g
+         ( $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done %%f/%%g || exit 1 )
 
 compile3-CMD: autoloads compile0-CMD
        for %%f in ($(WINS_BASIC3)) do for %%g in (%%f/*.el) do \
-         $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done %%f/%%g
+         ( $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done %%f/%%g || exit 1 )
 
 compile4-CMD: autoloads compile0-CMD
        for %%f in ($(WINS_BASIC4) $(WINS_CEDET) term obsolete) do for %%g in 
(%%f/*.el) do \
-         $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done %%f/%%g
+         ( $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done %%f/%%g || exit 1 )
 
 compile0-SH: autoloads
 #      for elc in $(lisp)/*.elc $(lisp)/*/*.elc; do attrib -r $$elc; done
        for el in $(COMPILE_FIRST); do \
          echo Compiling $$el; \
-         $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done $$el; \
+         $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done $$el || exit 1; \
        done
 
 compile1-SH: autoloads compile0-SH
@@ -359,7 +359,7 @@ compile1-SH: autoloads compile0-SH
            if test -f $$el; \
            then \
              echo Compiling $$el; \
-             $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done $$el; \
+             $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done $$el || exit 1; \
            fi \
          done; \
        done
@@ -370,7 +370,7 @@ compile2-SH: autoloads compile0-SH
            if test -f $$el; \
            then \
              echo Compiling $$el; \
-             $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done $$el; \
+             $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done $$el || exit 1; \
            fi \
          done; \
        done
@@ -381,7 +381,7 @@ compile3-SH: autoloads compile0-SH
            if test -f $$el; \
            then \
              echo Compiling $$el; \
-             $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done $$el; \
+             $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done $$el || exit 1; \
            fi \
          done; \
        done
@@ -392,7 +392,7 @@ compile4-SH: autoloads compile0-SH
            if test -f $$el; \
            then \
              echo Compiling $$el; \
-             $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done $$el; \
+             $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile-if-not-done $$el || exit 1; \
            fi \
          done; \
        done
@@ -405,8 +405,8 @@ compile-always: $(lisp)/subdirs.el 
compile-always-$(SHELLTYPE) doit
 
 compile-always-CMD:
 #      -for %%f in ($(lisp) $(WINS)) do for %%g in (%%f\*.elc) do @attrib -r 
%%g
-       for %%f in ($(COMPILE_FIRST)) do $(emacs) $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile %%f
-       for %%f in (. $(WINS)) do for %%g in (%%f/*.el) do $(emacs) 
$(BYTE_COMPILE_FLAGS) -f batch-byte-compile %%f/%%g
+       for %%f in ($(COMPILE_FIRST)) do ( $(emacs) $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile %%f || exit 1 )
+       for %%f in (. $(WINS)) do for %%g in (%%f/*.el) do ( $(emacs) 
$(BYTE_COMPILE_FLAGS) -f batch-byte-compile %%f/%%g || exit 1 )
 
 compile-always-SH:
 #      for elc in $(lisp)/*.elc $(lisp)/*/*.elc; do attrib -r $$elc; done
@@ -424,7 +424,7 @@ compile-always-SH:
 compile-calc: compile-calc-$(SHELLTYPE)
 
 compile-calc-CMD:
-       for %%f in ($(lisp)/calc/*.el) do $(emacs) $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile %%f
+       for %%f in ($(lisp)/calc/*.el) do ( $(emacs) $(BYTE_COMPILE_FLAGS) -f 
batch-byte-compile %%f || exit 1 )
 
 compile-calc-SH:
        for el in $(lisp)/calc/*.el; do \
@@ -593,15 +593,15 @@ install:
 # since cp does not preserve time stamps
 install-lisp-SH:
        cp -f *.el "$(INSTALL_DIR)/lisp"
-       for dir in $(WINS); do [ -d "$(INSTALL_DIR)/lisp/$$dir" ] || mkdir 
"$(INSTALL_DIR)/lisp/$$dir"; done
-       for dir in $(WINS); do cp -f $$dir/*.el "$(INSTALL_DIR)/lisp/$$dir"; 
done
-       for dir in . $(WINS); do cp $$dir/*.elc "$(INSTALL_DIR)/lisp/$$dir"; 
done
+       for dir in $(WINS); do [ -d "$(INSTALL_DIR)/lisp/$$dir" ] || mkdir 
"$(INSTALL_DIR)/lisp/$$dir" || exit 1; done
+       for dir in $(WINS); do cp -f $$dir/*.el "$(INSTALL_DIR)/lisp/$$dir" || 
exit 1; done
+       for dir in . $(WINS); do cp $$dir/*.elc "$(INSTALL_DIR)/lisp/$$dir" || 
exit 1; done
 
 install-lisp-CMD:
        cp -f *.el "$(INSTALL_DIR)/lisp"
-       for %%f in ($(WINS)) do if not exist "$(INSTALL_DIR)/lisp/%%f" mkdir 
"$(INSTALL_DIR)/lisp/%%f"
-       for %%f in ($(WINS)) do cp -f %%f/*.el "$(INSTALL_DIR)/lisp/%%f"
-       for %%f in (. $(WINS)) do cp -f %%f/*.elc "$(INSTALL_DIR)/lisp/%%f"
+       for %%f in ($(WINS)) do if not exist "$(INSTALL_DIR)/lisp/%%f" ( mkdir 
"$(INSTALL_DIR)/lisp/%%f" || exit 1 )
+       for %%f in ($(WINS)) do ( cp -f %%f/*.el "$(INSTALL_DIR)/lisp/%%f" || 
exit 1 )
+       for %%f in (. $(WINS)) do ( cp -f %%f/*.elc "$(INSTALL_DIR)/lisp/%%f" 
|| exit 1 )
 
 # WARNING: Do NOT split the part inside $(ARGQUOTE)s into multiple lines as
 #          this can break with GNU Make 3.81 and later if sh.exe is used.
---------------- 8< --------------- 8< --------------------------

But, sure enough, compilation then fails with

Compiling textmodes/rst.el

In toplevel form:
textmodes/rst.el:320:1:Error: Variable binding depth exceeds max-specpdl-size
mingw32-make[1]: *** [compile3-SH] Error 1
mingw32-make[1]: Leaving directory `C:/Users/Claudio/src/emacs/lisp'
mingw32-make: *** [bootstrap-gmake] Error 2

Is this expected? Should I increase max-specpdl-size somehow?

-- 
Claudio