Re: [PATCH] eww improvements

[Rüdiger Sonderfeld]

On Sunday 23 June 2013 20:29:55 Lars Magne Ingebrigtsen wrote:
> Ivan Kanis <address@hidden> writes:
> > I have attached 3 patches for eww.
> 
> Thanks; all applied.

http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/113144

I don't think

+  (cond ((eq system-type 'windows-nt)
+        'browse-url-default-windows-browser)
+       ((eq system-type 'darwin)
+        'browse-url-default-macosx-browser)
+       (t
+        'browse-url-netscape))

is a good choice for `eww-external-browser'.  Who still uses netscape? And why 
duplicate all the effort to find the default browser when this is already done 
in browse-url.el?

I think using `browse-url-default-browser' as default value makes more sense.

We could also try to use `browse-url-browser-function', unless it is set to 
eww itself:

  (if (memq browse-url-browser-function '(eww-browse-url eww))
        #'browse-url-default-browser
      browse-url-browser-function)

Regards,
Rüdiger