Re: filenotify.el

[Michael Albinus]

Stefan Monnier <address@hidden> writes:

>> It is more simple to implement for some Tramp file name handlers. For
>> example, in the smb case I have mapped file-notify-supported-p to
>> ignore. But of course I could implement it differently, let
>> file-notify-add-watch return with a file-notify-error in that case.
>
> I think it's not an either/or situation: it's important for
> file-notify-add-watch to return an error if it is not supported for that
> file, regardless of the existence of file-notify-supported-p.

I haven't meant to let behave file-notify-add-watch to return an error
just because of this. Of course, it shall return file-notify-error
anyway (marker to myself: we still must change it in w32notify.c). This
shall be checked in corresponding ert tests (next marker to myself).

Btw, file-notify-supported-p would ease to skip ert tests, if file
notification is not available for the local or remote case.

>         Stefan

Best regards, Michael.