[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'.
From: |
Paul Eggert |
Subject: |
Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'. |
Date: |
Sat, 12 Oct 2013 00:37:03 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 |
Daniel Colascione wrote:
> I haven't seen a single instance of a correct, side-effect-free assume
> resulting in incorrect code generation.
As far as I could tell, the generated code wasn't incorrect,
it was merely slower. I didn't measure the performance, but
the generated code did look worse (I could have been mistaken
of course).
Have you measured the user-visible performance of Emacs when
it internally uses eassume rather than eassert? Is there
a significant performance improvement? If not, perhaps we
should omit eassume, as not being worth the trouble.
- Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'., (continued)
- Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'., Eli Zaretskii, 2013/10/11
- Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'., Daniel Colascione, 2013/10/11
- Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'., Eli Zaretskii, 2013/10/11
- Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'., Daniel Colascione, 2013/10/11
- Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'., Dmitry Antipov, 2013/10/11
- Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'., Paul Eggert, 2013/10/11
- Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'., Daniel Colascione, 2013/10/11
- Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'.,
Paul Eggert <=
- Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'., Eli Zaretskii, 2013/10/11
- Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'., Daniel Colascione, 2013/10/11