[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] * lisp/progmodes/ruby-mode.el: Use `setq-local' where approp
From: |
Dmitry Gutov |
Subject: |
Re: [PATCH] * lisp/progmodes/ruby-mode.el: Use `setq-local' where appropriate. |
Date: |
Fri, 01 Nov 2013 07:43:06 +0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Bozhidar Batsov <address@hidden> writes:
> I think that we don't need to worry about compatibility with the other
> version of the ruby-mode in
> Ruby's SVN repo, since just about nobody uses it (except maybe some Emacs 23
> users?).
I think more importantly, no one's trying to merge the code from the
trunk ruby-mode back to the Ruby repo (at least, in its entirety), or
use this package separately from the Emacs trunk.
> ruby-mode suffers from a lot of legacy in it (compared to other built-in
> modes) and would
> definitely benefit from a clean up. After all, simpler code is always easier
> to improve, extend
> and debug.
+1
I can't say it's too hard to understand, but the code will be easier to
understand for a new reader without the (fboundp
'syntax-propertize-rules) mess at the end.