emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Mark custom function for interactive use only


From: Glenn Morris
Subject: Re: Mark custom function for interactive use only
Date: Mon, 25 Nov 2013 22:18:52 -0500
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

When installing changes by others, please think about the copyright
assignment aspect. The rule is, we can accept no more than 10-15 lines
total (cumulative over all changes) from any one person without an
assignment. Changes that fall under that rule should be marked "(tiny
change") in the ChangeLog.

I'd say this one qualifies as a tiny change (although it's more than 15
lines, much of it is mechanical). We would probably need a copyright
assignment to accept any more from this author, though.

Also, please try and use --author when you commit someone else's changes
(Emacs can do this for you).


BTW, I think it would be nicer if I could write:

  (put 'comint-run 'interactive-only 'make-comint)

instead of:

  (put 'comint-run 'interactive-only "Use `make-comint' instead")

Also, the installed change is inconsistent as to whether "Use `foo'
instead" should end in a period (I guess it should).

Also also, maybe "; use `foo' instead." with no preceding newline would
look better most of the time?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]