emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] About the :distant-foreground face attribute


From: Jan Djärv
Subject: Re: [PATCH] About the :distant-foreground face attribute
Date: Wed, 15 Jan 2014 07:33:02 +0100

Hello.

14 jan 2014 kl. 23:14 skrev Daniel Colascione <address@hidden>:

>> 
>>> Why is it okay to do that when there's no contrast problem, but suddenly, 
>>> when there's a contrast problem, we can say that the principle of following 
>>> system colors is important?
>> 
>> The principle of following system foreground is only important if system
>> background is used.
> 
> Then why don't we always use the system *selection* foreground color when we 
> use the system *selection* background? When we apply font-lock foreground 
> colors to a region you've highlighted, we're overriding your system's 
> selection foreground color. Why is it okay to override that color in some 
> situations but not others?

Because of bug http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15668.
Note that, as I said, Xcode, Eclipse and Visual Studio all does this as well, 
so it is not unheard of.

> 
>> This is currently for NS/Gtk+ only.  For Lucid/Motif/No toolkit, we don't use
>> system colors at all, because they are not known and can not be known,
>> because the API to get them is not available.
>> 
>>> You're applying this principle very selectively.
>> 
>> System background + contrast problem => system foreground.
>> How is that selectively, it is a clear rule.
> 
> It's clear, but arbitrary. Another clear and arbitrary rule is this:
> 
>  System background + contrast problem => adjust foreground.
> 
> You haven't presented any justification for your arbitrary rule being better 
> than my arbitrary rule.

I have stated my justification as such: User and system configurations should 
override Emacs settings and code in the default case, i.e. when the user has 
made no explicit customization in Emacs.

        Jan D.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]