[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Doc View Page Problems

From: Stefan Monnier
Subject: Re: Doc View Page Problems
Date: Tue, 15 Apr 2014 12:51:34 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

>         patch that will solve this problem.  What my fix does is updates
>         the default entry in `image-mode-winprops-alist' (the one with
>         key `t') to keep track of the current page.  Then when there are
>         no more windows to use, it uses the last known page.

Good idea.

> P.S.  I apologize if the bug mailing list would have been the
> appropriate mailing list to which to send this.

It would have worked as well, maybe even better.

> diff --git a/lisp/doc-view.el b/lisp/doc-view.el
> index 09d5925..0e8f511 100644
> --- a/lisp/doc-view.el
> +++ b/lisp/doc-view.el
> @@ -336,7 +336,7 @@ of the page moves to the previous page."
>        ;; Don't do it if there's a conversion is running, since in that case, 
> it
>        ;; will be done later.
>        (with-selected-window (car winprops)
> -        (doc-view-goto-page 1)))))
> +        (doc-view-goto-page (image-mode-window-get 'page t))))))

Could you provide a ChangeLog entry for that change?  Are we sure
(image-mode-window-get 'page t) can't return nil?

>      (setf (doc-view-current-page) page
> +          (image-mode-window-get 'page t) page      ;; Update the default 
> page.

Wouldn't it be better to do that directly inside image-mode-window-put?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]