[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] trunk r117002: Correctly treat progn contents as tople

From: Daniel Colascione
Subject: Re: [Emacs-diffs] trunk r117002: Correctly treat progn contents as toplevel forms when byte compiling
Date: Tue, 22 Apr 2014 10:04:14 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

On 04/22/2014 08:20 AM, Stefan Monnier wrote:
>>       `(defun ,member-name (,inst-arg &rest xargs)
>>          ,doc
>>          (declare (advertised-calling-convention (,inst-arg ,@xarglist)
>>                                                  ,emacs-version))
>>          (apply (cl-struct-slot-value ',iface-name ',member-name ,inst-arg)
>>                 ,inst-arg xargs)))))
> I think we'd be just as happy, with something like
>    (defun method-call (method inst &rest args)
>      (apply (funcall method inst) inst args))
> instead of defining umpteen "method call wrappers".

That way, you don't get docstrings, parameter-number checking, eldoc,
and so on. And you have to be aware that you're using this odd calling
convention instead of just calling a function like you would any other.
I'd much rather have the wrappers, which we can inline and make
practically free.

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]