Re: Changes in frame/window code

[martin rudalics]

>> (2) Fix the "toolbar/menubar height is part of the frame text height"
>>      issue (which the recent change in revision 117561 doesn't).
>
> What's wrong with that?

With emacs -Q and an internal tool bar evaluate one after the other

(frame-height)
(set-frame-height nil (1+ (frame-height)))
(frame-height)

Here the `set-frame-height' shrinks the frame.

> 0) Debug stubs (Vmy_debug_it in widget.c)?

Thanks for spotting them.  I have created the patch on Windows, so this
is indeed a leftover from the GNU/Linux platform debugging code.

> 1) It doesn't even compile with --enable-gcc-warnings (didn't you use it for
>     development?)

On GNU/Linux I always compile with --enable-gcc-warnings=yes
--enable-checking=yes --enable-check-lisp-object-type=yes

> due to missing 'x_clear_under_internal_border' prototype.

Sorry.  It's in xterm.h here (and thusly also mentioned in the
ChangeLog) but got lost in the transition to my Windows machine.

> 2) It crashes with both Lucid and Motif (after a few attempts to toggle
>     with M-x horizontal-scroll-bar-mode and drag):
> #0  0x000000379220f62b in raise (sig=6) at 
../nptl/sysdeps/unix/sysv/linux/pt-raise.c:37
> #1  0x000000000056bcbc in terminate_due_to_signal (sig=6, 
backtrace_limit=2147483647) at ../../trunk/src/emacs.c:387
> #2  0x00000000005f406d in die (msg=0x70acfe "VECTORLIKEP (a)", file=0x70acb8 
"../../trunk/src/lisp.h", line=866)
>      at ../../trunk/src/alloc.c:7102
> #3  0x0000000000566ba5 in XVECTOR (a=...) at ../../trunk/src/lisp.h:866
> #4  0x0000000000538106 in xt_action_hook (widget=0xd10060, client_data=0x0, 
action_name=0x138e2ec "EndScroll", event=0x7fffd5134100,
>      params=0x0, num_params=0x372f066290 <dummyAction.9840+16>) at 
../../trunk/src/xterm.c:4248

I can't reproduce that here - what precisely means "toggle with M-x
horizontal-scroll-bar-mode and drag"?  Dragging the slider with the
mouse?  Do you have to toggle more than once to make the bug happen?
Do you have any interpretation for what happened?

> 3) On Lucid, scroll bars are of the different colors (see screenshot).

I can't see such a thing here.  Is this with Xaw3D?

Thanks for the feedback, martin