[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] trunk r117640: * keyboard.c (safe_run_hook_funcall): A

From: Stefan Monnier
Subject: Re: [Emacs-diffs] trunk r117640: * keyboard.c (safe_run_hook_funcall): Avoid consing around
Date: Mon, 04 Aug 2014 18:35:56 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)

>> You remove the comment but don't fix the code accordingly: if the FIXME
>> is not valid any more, than we should cleanly pass `hook' as argument
>> rather than let-binding it to inhibit-quit.
> Hm...isn't it required to bind inhibit-quit to non-nil value before running
> hooks?

Yes, binding it to a non-nil value is necessary.  But that doesn't mean
that hook needs to be passed via that dynamic var.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]