[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] trunk r117941: Default to stack objects on non-GNU/Lin

From: Stefan Monnier
Subject: Re: [Emacs-diffs] trunk r117941: Default to stack objects on non-GNU/Linux, non-DOS_NT platforms.
Date: Thu, 25 Sep 2014 14:12:53 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)

>> IIUC the point of this new code is to improve performance
> Yes.  I should say that I've seen small but stable improvements before
> r117942,

It'd be good to see actual numbers.  I know that the performance
benefits for "average editing" is going to be negligible and I can live
with that, but I do want to see at least some real-use scenarios where
the benefit is tangible.

> but adding extra precautions against stack overflow makes
> them really negligible.  This means that we're going to an
> overengineered feature with no benefits.

I'm glad you feel that way.  When I saw this extra checking in
local_cons, I figured this is going to kill too much of the
performance gain.

> IMO we should make it fast rather than commonly used.

Right: the extra checks shouldn't fallback to Fcons but should
`abort' instead.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]