Re: cl-macro-expandall symbol definition is void

[Jostein Kjønigsen]

While I can work aroud this bug by this patch or a similar, I think it's
worth noting that csharp-mode worked fine prior to Emacs 24.4.

This means that some changes in core emacs now breaks derived c-modes.

So yes, we can work around this in csharp-mode (for now), but are we
100% sure we haven't broken any other derived c-modes in the process?

Wouldn't it be better to have this fixed in the -official- Emacs version
being distrubuted from the GNU website? If building Emacs from source
(master-branch) right now, the issue is already fixed. We might just
need a new build and that's it.

-- 
Jostein Kjønigsen
address@hidden / address@hidden

On Tue, Nov 25, 2014, at 11:35 PM, Glenn Morris wrote:
> 
> Following diff seems to make csharp-mode-0.8.5.el work fine for me.
> (Without the `eval-and-compile', it was uncompilable in any Emacs 24.x.)
> 
> Since it uses eg `set-difference', IMO it should in any case explicitly
> require cl and not rely on its other dependencies pulling it in.
> 
> *** csharp-mode-0.8.5.el.ORIG   2014-11-25 14:32:22.001787092 -0800
> --- csharp-mode-0.8.5.el        2014-11-25 14:31:13.608157922 -0800
> ***************
> *** 379,384 ****
> --- 379,385 ----
>   ;;    0.8.6 DPC 2011 May ??
>   ;;          -
>   
> + (eval-when-compile (require 'cl))
>   
>   (require 'cc-mode)
>   
> ***************
> *** 472,477 ****
> --- 473,479 ----
>     "Regex for matching directive blocks in ASP.NET files (.aspx, .ashx,
>     .ascx)")
>   
>   
> + (eval-and-compile
>   (defconst csharp-enum-decl-re
>     (concat
>      "\\<enum[ \t\n\r\f\v]+"
> ***************
> *** 484,490 ****
>      "\\)"
>      "\\)?")
>     "Regex that captures an enum declaration in C#"
> !   )
>   
>   ;; ==================================================================
>   
> --- 486,492 ----
>      "\\)"
>      "\\)?")
>     "Regex that captures an enum declaration in C#"
> !   ))
>   
>   ;; ==================================================================
>