[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Run hook when variable is set

From: Kelly Dean
Subject: Re: [PATCH] Run hook when variable is set
Date: Thu, 29 Jan 2015 08:20:27 +0000

Stefan Monnier wrote:
> NACK from me.

Why? Just because of the slowdown for symbols that have property lists? Or some 
additional reason?

I.e. if I eliminate the slowdown, then will you still have an objection to the 

> All that just to avoid using the minor mode?

The updated patch I sent you does make dynamic-cursor-mode be a minor mode 
rather than a defcustom, because you said you want it to be a minor mode. I 
didn't implement varhook in order to avoid that.

> I already posted the code
> that I think should be used for that minor mode.

And I explained why your code doesn't provide a complete solution. You didn't 

I implemented varhook to completely solve the problem of dynamic-cursor-mode 
interfering with other uses of cursor-type in all cases, while ensuring that 
dynamic-cursor-mode itself can reliably be (re)enabled in all cases.

Obviously, there are additional uses for this feature too. For just one 
example, without varhook, what solution would you propose for bug #19068?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]