[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] scratch/outline 834612f 3/5: lisp/outline.el (outline-

From: Oleh Krehel
Subject: Re: [Emacs-diffs] scratch/outline 834612f 3/5: lisp/outline.el (outline-mode): Clean up docstring
Date: Fri, 30 Jan 2015 09:16:14 +0100

On Fri, Jan 30, 2015 at 7:20 AM, Stefan Monnier
<address@hidden> wrote:
>>>>>> "Oleh" == Oleh Krehel <address@hidden> writes:
>> branch: scratch/outline
>> commit 834612fd984029b72f5c172bf3573aa7607fbe48
>> Author: Oleh Krehel <address@hidden>
>> Commit: Oleh Krehel <address@hidden>
>>     lisp/outline.el (outline-mode): Clean up docstring
>>     * lisp/outline.el (font-lock-warning-face): Remove unused declare.
>>     (outline-mode-prefix-map): Remove obsolete comment.
>>     (outline-font-lock-face): Remove obsolete comment.
> This patch seems to contain a lot of gratuitous re-indentation and other
> whitespace changes.  This are fine in the code you change, but
> not elsewhere.

Since I was making a change that would affect largely the whole file
in the subsequent commit, I changed the whitespace in the previous
commit, so that the next change would be easier to follow.

Should I redo the whole thing now to preserve the historical tabs?

I plan to make more changes in the future, the historical whitespace
will be overriden at some point eventually.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]