[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master f469024: Use delete-char instead of delete-back
From: |
Stefan Monnier |
Subject: |
Re: [Emacs-diffs] master f469024: Use delete-char instead of delete-backward-char. |
Date: |
Wed, 18 Mar 2015 23:18:04 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
> * lisp/leim/quail/hangul.el
> * lisp/progmodes/cperl-mode.el: Use delete-char instead of
> delete-backward-char, fixes compilation warnings.
The above doesn't use the right syntax. The right syntax looks like
* <filename> (<functionname>): blabla.
IOW you need to add the function names.
Please re-read
https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs
> @@ -2588,7 +2588,7 @@ Will untabify if `cperl-electric-backspace-untabify' is
> non-nil."
> (delete-region (point) p))
> (if cperl-electric-backspace-untabify
> (backward-delete-char-untabify arg)
> - (delete-backward-char arg)))))
> + (delete-char (- arg))))))
This doesn't look right: I think here we do want to run
delete-backward-char since this is part of a command which basically
extends the normal binding of DEL which is delete-backward-char.
Maybe we should call it interactively, tho.
Stefan
- Re: [Emacs-diffs] master f469024: Use delete-char instead of delete-backward-char.,
Stefan Monnier <=